Журнал изменений

Standardises all public-facing module controllers: converts tab indentation to 4-space (recommend, users), corrects copyright header encoding and year (2021/2022 → 2026) across modules that were outdated, shortens verbose loop variables to concise local names, and adds defensive directory handling in main/index.php to prevent warnings when the screenshots directory is absent.

Core changes:

1. main/index.php:

• Fix copyright year 2022 → 2026 and encoding © → ©
• Wrap opendir() in is_dir() + false check before loop
  • Prevents PHP warning when uploads/screens/thumb is missing
• Guard shuffle() call with if ($screens) to skip empty arrays
• Add closedir() inside the safe branch

2. recommend/index.php:

• Convert tabs to 4-space indentation throughout
• Fix copyright year 2021 → 2026

3. users/index.php:

• Convert tabs to 4-space indentation
• Rename verbose loop variables ($user_id → $uid, etc.)

4. account, faq, forum, help, jokes, links, media, money, news, order, pages, shop, whois, search, files, clients, changelog, auto_links, content, contact, sitemap, rss/index.php:

• Rename DB-prefixed destructured vars to short local names
• Normalise copyright encoding/year where broken (© → ©)
• CRLF → LF line-ending normalisation on Windows-edited files

Benefits:

• Consistent 4-space indentation across all frontend controllers
• Correct copyright year in all module headers (2026)
• No PHP warnings when optional directories are absent
• Shorter variable names reduce line width in dense row-rendering loops

Technical notes:

• No logic changes beyond the defensive is_dir() guard in main
• CRLF → LF applied automatically by git on staging
• Encoding fixes are cosmetic; runtime behaviour unchanged

Removes the stale templates/lite/0index.php which contained hardcoded site-specific navigation and SQL queries inside a presentation layer — a structural anti-pattern not compatible with the current template architecture. Also corrects a renamed variable reference in billing.html.

Core changes:

1. templates/lite/0index.php:

• Delete entire file (184 lines)
  • Contained hardcoded menu HTML, direct DB queries, and mixed presentation/business logic
  • Incompatible with {%placeholder%} template architecture

2. modules/money/templates/billing.html:

• Replace $site_logo with $logo to match renamed config variable
• Add missing newline at end of file

Benefits:

• Eliminates hardcoded SQL inside template layer
• Fixes broken variable reference in billing invoice template
• Reduces dead code footprint in templates/lite/

Technical notes:

• templates/lite/0index.php was not referenced by any active module
• billing.html $logo aligns with current config naming convention

Synchronize all project documentation with the changes implemented in the current modernization phase: getVar() coverage, func_get_args() elimination, tpl_eval/tpl_func/tpl_warn removal, setRedirect() introduction, filterMarkdown() addition, and migration progress update to ~80% complete.

Core changes:

1. README.md:

• Migration badge and text: 75% → 80% complete
• Tech Stack: added filterMarkdown() (safe Markdown parser) to Security line
• Completed section: added func_get_args() elimination, tpl_eval/tpl_func/tpl_warn removal, setRedirect(), filterMarkdown() entries
• Documentation table: added TESTS.md row

2. CONTRIBUTING.md:

• getVar() type reference: added 'let', 'word', 'title', 'field', 'raw' types; corrected 'var' description (was "Raw variable"; now "Alphanumeric/underscore/dash")
• Admin Module Conventions: replaced manual header()/exit section with full setRedirect() documentation including signature and all parameters
• Template Functions: tpl_eval/tpl_func/tpl_warn marked as fully REMOVED (not deprecated) — calling them causes fatal error

3. SECURITY.md:

• Version 6.3.0 changelog: added getVar() core coverage, func_get_args removed, tpl_eval/tpl_func/tpl_warn removed, filterMarkdown added, setRedirect added
• Removed (Insecure) table: added tpl_func() row, func_get_args() row, inline header()+exit row

4. UPGRADING.md:

• Template Functions migration: tpl_eval/tpl_func changed from "deprecated" to "fully removed — causes fatal error in 6.3.x"; added tpl_func() row
• New section: Admin Redirects — setRedirect() with full signature and examples
• New section: Admin Help Files — info file rename table (en.html → english.html)
• Migration Checklist: updated tpl_eval item, added setRedirect and info rename
• Version History: expanded Major Changes list with all 6.3 improvements

5. docs/TEMPLATES.md:

• [!WARNING] → [!CAUTION]: tpl_eval/tpl_func/tpl_warn have been REMOVED (not "will be removed") — updated wording and added tpl_func() to table

6. docs/TESTS.md:

• Minor alignment with current test suite structure

7. CODE_OF_CONDUCT.md:

• Added contribution guideline note for variable naming in examples and patches

8. docs/DISCUS.md / docs/PARSE.md:

• Status lines updated to reflect filterMarkdown() implementation status

Benefits:

• Documentation accurately reflects current codebase state
• getVar() type table is complete and correct for all contributors
• setRedirect() fully documented — replaces scattered header()/exit patterns
• No invented functionality — all documented features verified in source

Technical notes:

• docs/DISCUS.md and docs/PARSE.md are temporary working files
• filterMarkdown() signature: (string $src, bool $safe, string $mod): string
• setRedirect() signature: (string $url, bool $refer, int $code): never

Replace all positional $arg[N] variable references in HTML template files with named {%placeholder%} tokens compatible with setTemplateBasic(). This completes the migration from tpl_eval()/tpl_func() (removed) to the strtr-based template renderer introduced in SLAED 6.3.

Core changes:

1. Admin templates (templates/admin/*.html):

• login.html: $arg[1]→{%route%}, $arg[2]→{%nickname%}, $arg[3]→{%password%}, $arg[4]→{%captcha%}, $arg[5]→{%login%}
• registration.html: all $arg[N] → named placeholders
• comment.html: positional args → semantic names (username, avatar, rank, etc.)
• voting-close/open/post/view.html: updated to named placeholders
• index.php (admin theme entry): positional variable references updated

2. Default theme templates (templates/default/*.html):

• comment.html: $arg[1-25] → {%id%}, {%username%}, {%avatar%}, {%rank%}, {%post_count%}, {%user_rate%}, {%hclass%}, etc.
• login.html / login-logged.html / login-without.html: named placeholders
• privat-message.html: message template fully updated
• basic-search.html, basic-media-view.html: search/media templates updated
• liste-basic.html, liste-open.html: list templates updated
• block-voting.html: voting block placeholder names

3. Lite theme templates (templates/lite/*.html, templates/lite/0index.php):

• Same pattern applied: all $arg[N] → {%named%} placeholders
• comment.html, privat-message.html, basic-search.html, basic-media-view.html

Benefits:

• Template variables are now self-documenting (name conveys meaning)
• setTemplateBasic() uses strtr() with named keys — no eval() required
• Template maintenance simplified: no need to count positional arg indices
• All CRLF → LF normalized; missing EOF newlines added

Technical notes:

• setTemplateBasic(string $tpl, array $vars): string uses strtr($raw, $vars)
• Template files loaded from templates/$theme/$name.html by getThemeFile()
• Callers (module index.php files) updated to pass named key arrays

Add return type declarations to all module functions; replace list() with [] destructuring; update config access from module-specific globals ($conffo, $confnews, etc.) to $conf['module_name']['key']; modernize setHead() calls with explicit title arrays.

Core changes:

1. Return type declarations added (all 29 module index files):

• account(), newuser(), finnewuser() → : void
• forum(), topic_view(), post_add() → : void
• news(), view(), add_news() → : void
• All public-facing module functions now have explicit return types

2. list() → [] destructuring (modules with SQL result rows):

• forum/index.php: all while(list(...)) → while([...]) in topic/post loops
• files/index.php, media/index.php, shop/index.php, links/index.php
• news/index.php, pages/index.php, faq/index.php, jokes/index.php
• All sql_fetchrow() result assignments updated

3. Config access modernization (forum/index.php):

• global $conffo removed from all forum functions
• $conffo['listnum'] → $conf['forum']['listnum']
• $conffo['defis'] → $conf['forum']['defis']
• $conffo['pop'] → $conf['forum']['pop']
• $conffo['pnum'] → $conf['forum']['pnum']

4. setHead() with explicit titles (account/index.php):

• setHead() → setHead(['title' => _USERREGLOGIN])
• setHead() → setHead(['title' => _REGNEWUSER])
• setHead() → setHead(['title' => _ACCOUNTCREATED])
• Pattern applied across all account flow functions

5. Miscellaneous cleanup:

• Unused $catlink variable removed from forum/index.php
• whois/index.php: geo_ip lookup updated to current API
• search/index.php: query variable cleanup
• voting/index.php: type declarations added

Benefits:

• PHP 8.4 compatible — all functions have explicit return types
• $conffo/$confnews/etc. global removal reduces import surface
• list() removal aligns with PHP 7.1+ best practices throughout
• setHead() with title enables proper SEO meta generation

Technical notes:

• Config access via $conf['module']['key'] — no behavioral change
• [] destructuring is functionally identical to list() in all contexts
• 29 module files modified across 5 module subdirectories