Последнии сообщения форума
Finalize Phase 6–9 changes for the lite theme and clean up test support files after Phase 12 legacy removal.
Core changes:
- Lite theme layout migration (templates/lite/):
- Delete index.html and index-main.html (legacy shell files)
- Refactor index.php to data-only provider
- Update layouts/app.html and layouts/home.html to new engine contract
- Add partials: menu.html, forum-teaser.html, contact-block.html
- Add fragments: forum-pagenum.html, forum-teaser-item.html
- Admin theme fragments (templates/admin/fragments/):
- Add admin-lang-item.html and admin-menu-item.html
- Test suite (tests/):
- Remove getThemeLoad/getThemeFile stubs from ViewTestBootstrap.php
- Fix if/endif balance regex in TemplateValidationTest.php
- Remove stale lite-menu assertion in ViewBridgeSmokeTest.php
Benefits: - Lite theme fully decoupled from legacy shell rendering - All themes consistent with new Template engine contract - Test suite passes cleanly after legacy stub removal
Add automatic CSS/JS loading from theme directories, removing the need to manually list theme files in config. Remove legacy admin shell files and the archived default_old theme directory as part of Phase 12 cleanup.
Core changes:
- Universal theme asset loader (core/system.php):
Add getThemeAssets(theme, ext) — scans theme root, assets/vendor/*/, assets/{ext}/, and legacy js/ subdir in the correct load order
- Modify doCss() to auto-append theme CSS dirs (root, vendor, assets/css)
- Modify doScript() to auto-append theme JS files via getThemeAssets()
- Config decoupling (config/global.php):
Remove templates/[theme]/ and plugins/bootstrap/ from css_f (bootstrap now loaded from theme vendor dir automatically)
- Theme assets are fully discovered at runtime, not config-driven
- Legacy removal (templates/admin/, templates/default_old/):
- Delete templates/admin/index.html and index-home.html (Phase 12)
- Delete templates/default_old/ directory (archived legacy theme)
- Clean up templates/admin/index.php (data-only provider)
- Fix statistic path (core/user.php):
- Replace CONFIG_DIR with COUNTER_DIR for statistic.log read
Benefits: - Adding a new theme requires zero config changes for CSS/JS loading - Vendor libs bundled with a theme are picked up automatically - Load order guaranteed: root → vendor → assets/css|js
Technical notes: - getThemeAssets() uses glob() with GLOB_ONLYDIR for vendor subdirs - Applies to both frontend and admin rendering paths - Cache invalidation: existing CSS/JS caches are bypassed on next request
Replace the string-replace index.php pipeline in setHead()/setFoot() with $tpl->getHtmlPage(); introduce pages, layouts, partials and fragments for all themes; migrate setExit() in access.php and security.php to the same engine.
Core changes:
- Render pipeline (core/system.php):
- setHead() buffers output via ob_start() and stores vars in $sitevars / $adminvars
- setFoot() renders the full page via $tpl->getHtmlPage() using those vars
- Unified theme resolution: getTheme() no longer returns 'admin' for ADMIN_FILE
- $tpl always instantiated with resolved theme (no more separate admin branch)
- addblocks() calls for left/right/down/message/center/foot moved into setFoot()
- setExit() migration (core/access.php, core/security.php):
- Both versions replaced inline HTML with $tpl->getHtmlPage('message')
- alert fragment used for the error message body
- Template structure — new files per theme (admin, default, lite, simple):
- layouts: app.html, home.html, admin.html, bare.html
- pages: module.html, home.html, admin.html, login.html, message.html, preview.html
- partials: login.html, registration.html, searchbox.html, preview.html
fragments: block-left, code, comment, form-conf, hide, list-bottom, open, close, pagenum, panel-admin, panel-modul, quote, spoiler, voting-*, basic-monitor, basic
- Fragment updates:
- title.html extended in all themes with icon/subtitle/content layout block
- Theme head/foot vars (templates/admin/index.php, templates/lite/index.php):
getAdminHeadVars() / getThemeHeadVars() / getThemeFootVars() return plain array keys (no {%key%} format) to match the new Template data contract
- Fixes and tests:
- modules/news/index.php: guard is_user() before $user[1] access
tests: updated AdminLoginBridgeFlowTest, AdminPreviewBridgeFlowTest, AdminSearchboxBridgeFlowTest for unified theme; added ViewBridgeSmokeTest cases for module/home page render; added AdminPageRenderFlowTest
- Config:
- config/global.php: sitekey rotated, active theme set to 'simple'
Benefits: - Page rendering fully managed by the Template class for all themes and contexts - setHead/setFoot no longer depend on index.php file or string-replace placeholders - All three render contexts (frontend, admin, exit) use the same engine
Technical notes: - index.php file is no longer read or parsed by setHead/setFoot - {%placeholder%} vars in theme index.php files are no longer used for page assembly
Drop core/template.php content and all setTemplate* functions; wire all remaining call sites to $tpl->getHtmlFrag(); extract visitor tracking from setHead() into three dedicated functions.
Core changes:
- Legacy template system (core/template.php, core/system.php):
- Emptied core/template.php — all setTemplate* functions removed
- Switched require from core/template.php to core/classes/template.php
- Replaced $GLOBALS['tpl'] with direct global $tpl in closures
- Renamed param $tpl to $frag in setPageNumbers() and num_ajax()
- Fixed uninitialized $barr in getBlocks()
- Visitor tracking extraction (core/system.php):
- Extracted session tracking into updateSessionTrack()
- Extracted referer tracking into updateRefererTrack()
- Extracted statistics tracking into updateStatsTrack()
- Theme template function refactor (templates/admin/index.php, templates/lite/index.php):
- setTemplateHead() replaced by getAdminHeadVars() / getThemeHeadVars() — returns array
- setTemplateFoot() replaced by getThemeFootVars() — returns array
- setTemplateBlock() removed from both template files
- Call site migration (core/admin.php, core/user.php, admin/index.php, index.php):
- All remaining setTemplateBlock() and setTemplateWarning() calls replaced with $tpl->getHtmlFrag()
- Tests cleanup (tests/):
- Removed TemplateBridgeFallbackTest, TemplateBridgeFlowTest, TemplateIfTest, TemplateTest
- Updated ViewTestBootstrap and TemplateValidationTest for new class path
- Misc (modules/main/index.php, templates/default/layouts/main.html):
- Fixed mojibake in Russian content strings to proper UTF-8
- Added templates/default/layouts/main.html as new default layout file
Benefits: - Single Template class is now the only rendering engine; old string-replace system removed - Visitor tracking isolated in named functions; setHead() reduced in scope - Theme functions return data arrays instead of rendered strings
Technical notes: - setTemplateBlock(), setTemplateWarning(), setTemplateBasic() no longer exist - storage/counter/ips.log removed from version control
Core changes: - modules/order/admin/info/russian.html: removed (replaced by Markdown) - modules/order/admin/info/ru.md: new Markdown version of order admin docs - admin/info/database/ru.md: updated database admin documentation
Extended description: Complete replacement of setTemplateBasic() calls with $tpl->getHtmlFrag() in the core system files.
Core changes: - core/system.php: code, quote, hide, categories fragments via $GLOBALS['tpl'] - core/admin.php: admin panel core helpers - core/template.php: template engine core - core/user.php: user system helpers
Benefits: - Core layer fully migrated to new Template API - setTemplateBasic() can now be considered deprecated/unused
Extended description: Complete replacement of setTemplateBasic() calls with $tpl->getHtmlFrag() in all remaining frontend module index.php and common.php files.
Core changes: - modules/auto_links/index.php - modules/changelog/common.php - modules/clients/index.php - modules/content/index.php - modules/faq/index.php, files/index.php, forum/index.php - modules/help/index.php, jokes/index.php, links/index.php - modules/media/index.php, news/index.php, pages/index.php - modules/search/index.php, users/index.php - modules/voting/index.php, whois/index.php
Benefits: - All frontend modules now use unified Template API - Completes the full setTemplateBasic -> getHtmlFrag migration
Extended description: Complete replacement of setTemplateBasic() calls with $tpl->getHtmlFrag() in admin/index.php and all admin/modules/*.php files.
Core changes: - admin/index.php: main admin entry point - admin/modules/*.php: 24 admin panel modules (admins, blocks, categories, comments, config, database, editor, favorites, fields, groups, lang, messages, modules, monitor, newsletter, privat, ratings, referers, replace, scheduler, security, statistic, template, uploads)
Benefits: - Completes full admin layer migration to Template API - monitor.php: nested helper arrays cleaned of {%key%} wrappers
Technical notes: - global $tpl; moved inside function bodies where needed - basic-monitor.html handles 60+ variables via flat key/value map
Extended description: Complete replacement of setTemplateBasic() calls with $tpl->getHtmlFrag() across all 23 module admin/index.php files.
Core changes: - 23 files: modules/*/admin/index.php - Primary patterns: open, close, form-conf fragments - Added global $tpl; where missing inside function bodies
Benefits: - Uniform Template API across entire admin layer - Fragments resolved from templates/admin/fragments/ directory
Technical notes: - setTemplateBasic('open') -> $tpl->getHtmlFrag('open', []) - setTemplateBasic('form-conf', ['{%key%}' => $val]) -> $tpl->getHtmlFrag('form-conf', ['key' => $val])
Extended description: Complete replacement of all setTemplateBasic() calls with $tpl->getHtmlFrag() in the account and shop frontend modules.
Core changes: - modules/account/index.php: migrated ~57 calls across all functions (newuser, finnewuser, view, profil, last, privat, favorites, passlost, passmail, edithome) - modules/shop/index.php: migrated 24 calls across all functions (shop, liste, view, kasse, clients, rech, partners) - Added global $tpl; declarations to clients() and rech() functions in shop
Benefits: - Consistent Template API usage across all frontend modules - Auto-escaped output via {{ }} prevents XSS by default - Flat key/value arrays instead of nested {%key%} wrappers
Technical notes: - if_flag booleans flattened: ['if_flag' => ['bool' => $x]] -> ['key' => $x] - Raw HTML passed via {{{ }}} triple braces in templates





