changelog

String literal modernization (PHP Best Practice):
1. Template functions:
- Line 91: tpl_warn() → setTemplateWarning() (missed)
- Line 89, 169: String concatenation with single quotes
2. String literals "" → '':
- Line 98: $cnst_tmp initialization
- Line 116: Ternary operator defaults
- Line 117: isset() default value
- Line 121: trim() default
- Line 123-127: CSS class names
- Line 163-165: Array literals
- Line 168: PHP closing tag
- Line 170: fopen() mode
- Line 174: referer() URL
- Line 181: end_chmod() path
Best Practice:
• Use '' for strings without variable interpolation
• Faster parsing, cleaner code
• Consistent with modern PHP standards

Missed modernizations from previous commit:
1. lang_main() templates:
- Line 33: tpl_eval('open') → setTemplateBasic('open')
- Line 66: tpl_eval("close", "") → setTemplateBasic('close')
2. lang_file() array syntax:
- Line 86: array() → []
- Line 103: array() → []
All array() and tpl_eval() now modernized consistently.

Applied MODERNISIERUNG_RULES v2.0:
1. Modern Array Syntax (Kapitel 11)
- array() → [] (6 occurrences)
- Lines: 13, 14, 78, 79, 127, 151, 163, 164
2. Function Return Types (Kapitel 12)
- lang_main(): void
- lang_file(): void
- lang_save(): void
- lang_conf(): void
- lang_info(): void
3. Modern Template Functions (Kapitel 16)
- tpl_eval('open') → setTemplateBasic('open')
- tpl_eval('close') → setTemplateBasic('close')
- tpl_warn() → setTemplateWarning() with array parameters
Changes:
• All array() syntax replaced with []
• All functions typed with void return type
• Modern template API throughout
• Consistent with MODERNISIERUNG_RULES v2.0

Added 11 new chapters based on admins.php analysis:
11. Modern PHP Array Syntax
- array() → [] (PHP 7+ standard)
12. Function Return Types
- void, string, int, array, bool
- Type safety for all functions
13. getVar() mit 'req' Source
- GET/POST flexible parameter handling
- Use case: Edit forms with ID from GET
14. PDO Prepared Statements - Parameter-Formatierung
- Inline: ≤3 parameters
- Multi-line: ≥4 parameters for readability
15. Boolean zu Integer Konvertierung für DB
- Checkboxen: bool → TINYINT(1)
- Pattern: getVar('bool', 0) ? 1 : 0
16. Template-Funktionen (Modern)
- setTemplateWarning() statt tpl_warn()
- setTemplateBasic() statt tpl_eval()
17. getAdminTabs() statt navi_gen()
- Modern API with [] instead of ''
- Shorter parameter list
18. Header Redirects mit dynamischen Query-Parametern
- Optional parameters: ($send ?? '')
19. Validation Arrays
- $stop[] pattern für Fehlersammlung
- Better UX: Show all errors at once
20. Zusammenfassung erweiterte Regeln
- ✅ DO: 8 additional patterns
- ❌ DON'T: 5 additional anti-patterns
21. Vollständiges Beispiel (admins.php Style)
- Complete function with all modern patterns
Version: 1.0 → 2.0
Total: 21 chapters, 600+ lines
Reference: admins.php as complete example

Modernized all input handling and config save:
1. lang_navi()
- func_get_args() → typed parameters
- Added return type: string
2. lang_file()
- $_GET['mod_dir'] → getVar('get', 'mod_dir', 'var', '')
- $_GET['adm_fl'] → getVar('get', 'adm_fl', 'bool', false)
- $_GET['lng_wh'] → getVar('get', 'lng_wh', 'var', '')
3. lang_save()
- $_POST['mod_dir'] → getVar('post', 'mod_dir', 'var', '')
- $_POST['lwh'] → getVar('post', 'lwh', 'var', '')
- $_POST['lcn'] → getVar('post', 'lcn[]', 'var') (bracket notation)
- $_POST['cnst'] → getVar('post', 'cnst[]', 'var')
- $_POST['lng'] → getVar('post', 'lng', 'var', [])
4. lang_conf_save()
- $_POST → getVar() for all inputs
- save_conf() → setConfigFile() (modern API)
- Compact array-based config structure
- Added void return type
Benefits:
• Consistent input filtering across module
• Type safety with modern PHP 8 patterns
• Bracket notation for arrays
• Secure config file handling

Created MODERNISIERUNG_RULES.md with complete guidelines for:
1. getVar() Array Handling
- FILTER_REQUIRE_ARRAY → getVar('post', 'field[]', 'num')
- Bracket notation patterns
2. Compact Config-Save Functions
- Inline getVar() in $cont arrays
- Elvis operator for defaults
- Eliminate intermediate variables
3. Remove Redundant Code
- intval() checks when using getVar('num')
- stripslashes() (PHP 8+)
- array_map('intval') after filtered arrays
4. Modern PHP Patterns
- Typed function parameters
- setConfigFile() 4th parameter
- Inline processing
5. Migration Checklist
- Step-by-step modernization guide
- DO/DON'T rules
- Commit message templates
Purpose: Enable consistent modernization across different
code instances (work/home environments)

Core improvements:
• core.php: Modernize setArticleNumbers() with typed parameters
* func_get_args() → named parameters with types
* Improved SQL with prepared statements support
* Better category access control logic
• security.php: Fix config path
* config_users.php → users.php (consistent naming)
• config/users.php: Add modern users config file
Admin modules:
• database.php: Add new database() overview function
* SHOW TABLE STATUS with detailed metrics
* Exact row counts via COUNT(*)
* Size calculations (Data + Index + Free)
* Support for optimize/repair operations
• groups.php: Code formatting + setConfigFile() fix
* Multi-line if → one-liner (consistency)
* SQL arrays formatted inline
* setConfigFile() now receives $confu parameter

• admins.php: 2 occurrences (admins_add, admins_save)
• comments.php: 1 occurrence (comm_del)
• blocks.php: 2 occurrences (blocks_add_save, blocks_change)
Changed pattern:
filter_input(INPUT_POST, 'field', FILTER_DEFAULT, FILTER_REQUIRE_ARRAY) ?? []
→ getVar('post', 'field[]', 'num') ?: []
Simplified array processing:
is_array($arr) ? implode(',', array_map('intval', $arr)) : ''
→ $arr ? implode(',', $arr) : ''
(getVar with 'num' type already returns filtered integers)
Consistent with modern getVar() API across entire admin module

• sitemap_save(): filter_input() → getVar('post', 'mod[]', 'num')
• users_save(): Restructured to compact inline style
* Eliminated 25 intermediate variables
* Removed redundant validation block
* getVar() calls directly in $cont array
* Elvis operator for defaults
* Inline processing (strtolower, strtr)
Reduces users_save() from 60+ lines to 33 lines
Consistent with modern getVar() bracket notation pattern

Validationsblock simplified (Lines 586-601):
• Redundant intval() checks removed (getVar 'num' already returns int)
• Elvis-Operator (?:) instead of ternary operator with !intval()
• stripslashes() removed (PHP 8 compatible - Magic Quotes deprecated)
• Logical code grouping: String-Defaults, Numeric-Defaults, processed strings
• String-Interpolation instead of concatenation in Heredoc
Advantages:
✓ Reduced code complexity without behavior change
✓ Moderne PHP-Syntax (Elvis-Operator, String-Interpolation)
✓ Better readability with clear structure
✓ PHP 8+ compatible