Журнал изменений
Add unused constants detection to PHPUnit, fix token analysis bug in security test, and remove standalone script replaced by the new test.
Core changes:
- Unused constants test (tests/LanguageValidationTest.php):
- Add testNoUnusedConstants() that dynamically discovers all ru.php files
- Scans entire codebase (core, admin, modules, blocks, templates, setup)
- Excludes language directories from search to avoid self-matches
- Reports file path and constant name for each unused definition
- Security test fix (tests/SecurityValidationTest.php):
- Fix testNoIncludesInsideFunctions() token analysis bug
- T_WHITESPACE between T_FUNCTION and function name was resetting nextIsFuncName flag, causing all include/require detections to fail
- Skip whitespace and comment tokens in the flag reset condition
- Removed standalone script (tests/check_constants.php):
- Functionality fully covered by new PHPUnit testNoUnusedConstants()
- PHPUnit test is broader: checks all module language files automatically
Benefits:
- Automated detection of dead language constants in CI pipeline
- Security test now correctly identifies include/require inside functions
- Single test runner (PHPUnit) for all validation checks
Add missing SEO constants to non-Russian admin language files and remove unused constants detected by the new automated validation test.
Core changes:
- Added missing constants (admin/language/{en,de,fr,pl,uk}.php):
- _TSEP: Title separator for SEO URLs
- _SEOTITLE: Add title toggle label
- _SEOCTITLE: Add category title toggle label
- Removed unused _A_LINKS_LOGO (modules/auto_links/language/):
- Constant not referenced anywhere in application code
- Removed from all 6 language files (ru, en, de, fr, pl, uk)
- Removed unused _CSIZE (modules/clients/):
- Removed from admin/language/ (6 files) and language/ (6 files)
- Total: 12 files cleaned
- Removed unused _NEW_LINKS (modules/links/language/):
- Removed from all 6 language files
Benefits:
- All languages have complete set of admin SEO constants
- No dead constants cluttering language files
- Automated test now passes for constant usage validation
Fix config save function that double-encoded HTML in graph, schema, and mtemp fields through save_text() when admin editor was enabled.
Core changes:
- Config save function (admin/modules/config.php):
- Switch graph, schema, mtemp fields from 'text' to 'raw' type in getVar()
- Remove unnecessary preg_replace for <br> tag stripping
- Prevents save_text() from applying htmlspecialchars() to already-encoded HTML
- Global config (config/global.php):
- Update Schema.org context URLs from http to https
- Store raw quotes in graph/schema templates instead of HTML entities
- Alphabetical key reordering, add tsep separator setting
- Update slogan text
- Directory index (config/index.html):
- Update redirect URL from http://www.slaed.net to https://slaed.net
Benefits:
- Eliminates progressive corruption of template fields on each save
- Correct HTML output for OG meta tags and JSON-LD schema
- HTTPS everywhere for external URLs
Technical notes:
- Fields with 'raw' type bypass save_text() processing entirely
- Output in core/system.php uses str_replace() on raw values, no encoding needed
Align block management URLs with the standard module routing convention used across the admin panel (name=blocks&op=action&id=N).
Core changes:
- Block toggle function (admin/modules/blocks.php):
- Rename parameter 'bid' to 'id' for consistency with other modules
- Update SQL binding to match new parameter name
- Block listing URLs (core/admin.php):
- Change action URLs from legacy format (op=blocks_change&bid=) to unified format (name=blocks&op=change&id=)
- Update edit and delete links to match new routing scheme
Benefits:
- Consistent URL scheme across all admin modules
- Eliminates legacy routing format for block management
Remove legacy blocks and plugins that depend on obsolete technologies (Flash SWF player, IPB forum integration) no longer supported by modern browsers.
Core changes:
- Removed blocks (blocks/):
- block-radio.php: Flash-based SWF radio player block
- block-ipb_center_forum.php: IPB forum integration block with raw SQL
- Removed radio plugin (plugins/radio/):
- mju.swf: Flash player binary
- playlist.mpl: Radio station playlist with dead stream URLs
- radio.html: Popup window for radio player
- index.html: Directory index redirect
Benefits:
- Reduces attack surface (raw SQL in IPB block, Flash vulnerabilities)
- Removes dead code depending on discontinued technologies
- Cleaner project structure without obsolete third-party integrations
Migrate all 98 getHref() calls in 16 files to the new getSeoUrl() with named parameters. Remove getHref() (75 lines dead code), getUrlMeta() and its dead callers from core. Delete unused config_seo.php.
Utility script to detect define() constants in language files that are not referenced anywhere in the codebase.
- Checker (tests/check_constants.php):
- Parses all define() constants from a given language file
- Searches core, admin, modules, blocks, templates, setup directories
- Reports unused constants with line numbers and values
- Usage: php tests/check_constants.php [language_file]
Meta keywords have been ignored by search engines since 2009. This commit removes the entire keyword system and migrates Open Graph / Schema.org settings from static $confse to admin-managed $conf.
Core changes:
- Keyword removal (config/global.php, config_seo.php, config.php):
- Remove 7 config keys: keys, dkeys, kwords, kletter, kmix, ksep, akeys
- Remove keyword form fields and save handlers from admin UI
- Delete 3 block files: block-keywords*.php
- Keyword removal (core/system.php, core/user.php):
- Remove keyword auto-generation in getHref()
- Remove <meta name="keywords"> output from head()
- Remove <Tags> from OpenSearch XML
- OG/Schema migration (config/global.php, admin/modules/config.php):
- Move agraph, graph, aschema, schema from $confse to $conf
- Add admin UI fields for Open Graph and Schema.org templates
- Safety fix (core/system.php):
- Add is_user() guard for $uid = intval($user[0])
- Language cleanup (admin/language/, language/):
- Remove 12 keyword constants from 6 admin language files
- Remove 7 unused constants from admin language files
- Remove 15 unused constants from 6 frontend language files
Benefits:
- Cleaner codebase without dead keyword functionality
- OG/Schema templates editable from admin panel
- No more undefined variable warnings
Technical notes:
- $kprotect in save() retained (used for bots, css_f, script_f)
- getUrlMeta() already deactivated, no DB changes needed
- config/config_seo.php cleaned but kept for remaining OG/Schema defaults
Simplify img_find() by removing global $theme side-effect and adding static cache. Comment out SEO settings now managed via admin panel.
Core changes:
- img_find() optimization (core/system.php):
- Remove global $theme variable manipulation
- Add static $base cache for theme image path
- getTheme() called once per request instead of every invocation
- Preserves per-user/admin theme resolution via getTheme()
- SEO config cleanup (config/config_seo.php):
- Comment out $confse['adesc'] and $confse['dletter']
- Values now managed through admin interface via $conf
Benefits:
- Cleaner img_find() without global state side-effects
- Single source of truth for SEO settings in admin panel
Resolve multiple PHP 8.x warnings from error logs and ensure HTTP errors (404/400) terminate with a clean SLAED error page instead of continuing execution and feeding crawler traps.
Core changes:
- Null-safety for $conff access (templates/lite/index.php):
- Add !empty($conff) guard before accessing $conff['defis']
- Prevents "array offset on null" when files module not loaded
- Fallback for unknown file types (core/system.php):
- Add null coalescing for $conftp[$type] in encode_attach()
- Handles .mid/.avi and other unmapped extensions gracefully
- Fix fields_in() globals (core/system.php):
- Replace require_once with global $conffi declaration
- Config already loaded; avoids redundant include
- HTTP error handling (core/security.php):
- Call setExit() after logging HTTP errors to terminate request
- Use $conf['theme'] for logo path in setExit() instead of img_find()
- img_find()/getTheme() not available during early boot
Benefits:
- Eliminates ~290 PHP warnings per day from bot traffic
- Stops crawler trap caused by bots following links on error pages
- Clean exit page with logo and auto-redirect for HTTP errors