Журнал изменений

System Architecture Modernization

1. Auto-Discovery System (admin.php)

✓ Replaced manual links.admin.php with auto-discovery ✓ Scans admin/modules/ directory dynamically ✓ New routing: ?name={module}&op={action} ✓ Loads only requested module (vs loading ALL modules) ✓ Added getAdminModuleMeta() for module metadata

2. Function Name Simplification (All 16 Modules)

✓ Removed redundant module prefixes from all functions ✓ Pattern: adminsShow() → admins(), adminsAdd() → add() ✓ Main function named after module: admins(), blocks(), etc. ✓ Switch statements use default: case for main function ✓ Navi functions keep full name: adminsNavi(), blocksNavi()

3. File Changes

✓ configure.php → config.php (renamed) ✓ admin/links/links.admin.php (deleted - no longer needed!)

Modules Refactored (16 total):

• admins: admins(), add(), save(), info()
• blocks: blocks(), new(), add(), edit(), file(), fix()
• categories: categories(), add(), edit(), save(), fix()
• changelog: changelog(), conf(), confsave(), info()
• comments: comments(), edit(), editsave(), conf()
• config: config(), save(), info()
• database: database(), dump(), info()
• editor: editor(), header(), rewrite(), htaccess(), robots()
• favorites: favorites(), conf(), confsave()
• fields: fields(), saveconf(), info()
• groups: groups(), add(), save(), points()
• lang: lang(), file(), save(), conf(), confsave()
• messages: messages(), add(), save(), delete()
• modules: modules(), edit(), info()
• newsletter: newsletter(), add(), save()
• privat: privat(), conf(), confsave()

Benefits:

✅ Cleaner code - no redundant prefixes ✅ Faster - loads only needed module ✅ Auto-discovery - new modules appear automatically ✅ RESTful URLs - consistent name/op pattern ✅ Maintainable - single source of truth in getAdminModuleMeta() ✅ No manual menu file to maintain

Converted 3 admin modules + menu to RESTful URL structure:

• admin/links/links.admin.php: Updated all menu links
• admin/modules/admins.php: name=admins&op={action}
• admin/modules/blocks.php: name=blocks&op={action}
• admin/modules/categories.php: name=categories&op={action}

New URL pattern: ?name={module}&op={action}

• Separates resource (module) from action (operation)
• Simplified switch cases: 'show', 'add', 'save' vs 'moduleShow', 'moduleAdd'
• Updated all forms, redirects, and navigation

Major changes:

• PDO-only architecture (removed mysqli support)
• All SQL queries converted to prepared statements with named placeholders
• Single quotes throughout for performance optimization
• Language files standardized (lang-english.php → en.php)
• PHP 8.1 version check enforced
• sprintf format specifiers fixed (%1$s not %1\$s)

• Dead code elimination:

  • Removed buildSelect() function (unused)
  • Removed 6 unused dropdown variable assignments

• Code cleanup:

  • Extracted checkWritableConfig() helper to reduce duplication
  • Improved maintainability and DRY compliance

Security improvements:

• PDO parameter binding prevents SQL injection
• Automatic type handling and escaping

Improve the language path helper function to return a complete path instead of an array of path segments, making the code more intuitive.

Changes

Function Signature:

BEFORE:

function lang_get_path(string $mod, string $typ): array {
    $mod_dir = $mod ? 'modules/'.$mod.'/' : '';
    $lng_wh = $typ ? $typ.'/' : '';
    return [$mod_dir, $lng_wh];
}

function getLangPath(string $mod = '', string $typ = ''): string {
    $base = BASE_DIR;
    $module = $mod ? '/modules/'.$mod : '';
    $type = $typ ? '/'.$typ : '';
    return $base.$module.$type.'/language';
}

Usage Simplification:

BEFORE (complex):

[$mod_dir, $lng_wh] = lang_get_path($mod, $typ);
$lang_path = BASE_DIR.'/'.$mod_dir.$lng_wh.'language';
$lng_src = BASE_DIR.'/'.$mod_dir.$lng_wh.'language/lang-'.$lng_cn[$j].'.php';

$lang_path = getLangPath($mod, $typ);
$lng_src = $lang_path.'/lang-'.$lng_cn[$j].'.php';

Benefits

✅ Single source of truth for language directory paths ✅ No array destructuring needed ✅ Follows verbNoun naming convention (getLangPath) ✅ Default parameters allow optional mod/typ ✅ Returns complete path - more intuitive API ✅ Reduced code duplication (3 places simplified) ✅ Easier to understand and maintain

Files Modified

• admin/modules/lang.php:

  • Renamed: lang_get_path() → getLangPath()
  • Updated: 3 call sites (lang_file, lang_save)
  • Removed: Array destructuring [$mod_dir, $lng_wh]
  • Simplified: Path construction logic

Testing

• Syntax check: ✅ No errors

• Path construction works for:

  • System languages: getLangPath() → BASE_DIR/language
  • Admin languages: getLangPath('', 'admin') → BASE_DIR/admin/language
  • Module languages: getLangPath('news') → BASE_DIR/modules/news/language
  • Module admin: getLangPath('news', 'admin') → BASE_DIR/modules/news/admin/language

Modernize language management admin module to PHP 8.4+ standards and document new refactoring patterns discovered during migration.

admin/modules/lang.php Changes

Navigation Function Modernization:

• Replace navi_gen() with getAdminTabs()
• Simplify function signature: remove unused $opt and $legacy parameters
• lang_navi(int $opt, int $tab, int $subtab, int $legacy) → lang_navi(int $tab, int $subtab)
• Update all 5 function calls throughout the module

Config Include Modernization:

• Replace include('config/config_lang.php') with require_once CONFIG_DIR.'/lang.php'
• Use checkConfigFile('lang.php') instead of end_chmod() for permission checking
• Update config file reference: config_lang.php → lang.php in setConfigFile()

Error Handling Improvements:

• Remove @ error suppression from opendir() call
• Add explicit false check: if ($dir === false) { ... }
• Proper error handling with early return

Code Style Improvements:

• Compact one-liners for simple if statements (following 120 char limit):

  • if ($file !== '.' && $file !== '...' && is_file(...)) $mod[] = $file;
  • if (is_dir(...)) $eadmin = '<a...';
  • while (($file = readdir($dir)) !== false) if (preg_match(...)) $lng_cn[] = ...;
  • for ($j = 0; $j < $cj; $j++) $cont .= '<input...';
• Improved readability while maintaining consistency

Language File Generation Fix:

• Remove \r\n (CRLF) → use PHP_EOL (LF) for line endings
• Remove closing ?> tag from generated language files
• Replace double quotes with single quotes: "define(...)" → 'define(...)'
• Generated files now fully comply with PSR-12 and SLAED standards

Minor Cleanups:

• Remove unnecessary comment "// Redirect back to same page"
• Consistent spacing and formatting

.

Added three new refactoring patterns based on lang.php migration:

Section 2.8: Remove Error Suppression Operator (@)

• Never use @ operator - handle errors properly
• Examples: @opendir() → explicit opendir() + if ($dir === false)
• Rule: Remove @ and check return values explicitly

Section 2.9: Compact Code Style (One-liners)

• For simple conditions, use compact syntax (max 120 chars)

• Examples:

  • if (condition) $var = value; (instead of multi-line)
  • foreach ($arr as $item) if (check) $result[] = $item;
• Rule: Single-statement conditions can be one-liners

Section 2.10: Config File Modernization

• Use require_once CONFIG_DIR.'/filename.php' instead of include()
• Use checkConfigFile('filename.php') instead of end_chmod()
• Remove config_ prefix: config_lang.php → lang.php
• Consistent config handling across modules

Updated Checklist (Section 14):

Added new items to migration checklist:

• Remove all @ error suppression operators
• Use compact one-liners for simple if/for/while (max 120 chars)
• Update config includes to use CONFIG_DIR constant
• Use checkConfigFile() instead of end_chmod()
• Rename config files: remove config_ prefix where applicable

Benefits

✅ Cleaner navigation function signature (2 params instead of 4) ✅ Proper error handling without suppression ✅ Modern config file organization ✅ Generated language files comply with LF line endings ✅ More compact, readable code style ✅ Documented patterns for future refactoring

Testing

• Syntax check: ✅ No errors (php -l admin/modules/lang.php)
• Config file loading: Uses new CONFIG_DIR constant
• Language file generation: Now creates LF files without closing tag
• All 5 lang_navi() calls updated and working