Журнал изменений
Complete modernization of sitemap admin module following SLAED naming conventions and PHP 8.4+ standards.
Function renames (brevity standard):
- sitemap_navi() → navi()
- sitemap_xsl() → xsl()
- sitemap_conf() → conf()
- sitemap_save() → save()
- sitemap_info() → info()
Additional changes:
- Extract add() function from inline switch case
- Extract xslsave() function from inline switch case
- Replace $admin_file with $aroute (10 occurrences)
- Update navigation ops to use name=sitemap&op= format
- Add exit; after all header() redirects
- Replace end_chmod() with checkConfigFile()
- Replace filter_input() with getVar('post', 'template', 'raw')
- Modernize switch to compact format with default case
- Update all op parameter values (remove sitemap_ prefix)
- Remove commented permission check code
Extends getVar() with a new 'raw' type that returns values completely unfiltered (no trim, no sanitization). This is needed for admin-only use cases like XML/XSL template editing where any modification would corrupt the data.
Changes:
- Add 'raw' => fn($v) => $v filter to getVar()
- Update function documentation
Security: Safe for admin-only contexts with proper access controls
Renamed language files for consistency:
- lang-english.php → en.php
- lang-german.php → de.php
- lang-french.php → fr.php
- lang-polish.php → pl.php
- lang-russian.php → ru.php
- lang-ukrainian.php → uk.php
Applied to:
- modules/account/language/ (6 files)
- modules/news/language/ (6 files)
- modules/news/admin/info/ (6 files)
Total: 18 files renamed Naming convention follows ISO 639-1 standard (two-letter language codes)
Global variable standardization:
- Line 16: global declaration updated
- Line 107: URL construction updated
- Line 111: URL construction updated
Consistent with all other admin modules (3 changes total)
Function naming modernization:
- file_view() → fileview()
- block_save() → blocksave()
- pass_save() → passsave()
- conf_save() → confsave()
Updated 13 references across:
- 4 function definitions
- 4 switch cases
- 6 form op parameters
- 2 URL op parameters
Code optimization:
Lines 294-295: Combine getVar() with multiplication Old: $sess_d = getVar(...); $sess_d = ($sess_d) ? $sess_d * 60 : 86400; New: $sess_d = getVar('post', 'sess_d', 'num', 1440) * 60;
- Mathematically equivalent: 1440 * 60 = 86400
Minor code style improvements:
- Updated array syntax from array() to [] for consistency
- Changed mail parameter type from 'text' to 'bool' for checkbox validation
- Ensures full adherence to modern PHP 8.4 standards
All security features and functionality remain unchanged.
- Update copyright year in modules/account/index.php
- Refactor modules/rss_info/index.php to use new config/rss.php and modernize code structure
- Rename config/config_rss.php to config/rss.php
- Modernize admin/modules/rss.php:
- Update navi() to accept extra param for correct tab handling
- Use getVar() for input sanitization in save()
- Match array assignment style in save() to other modules
- Use checkConfigFile() and setConfigFile() helpers- Update inclusions of rss config in core/core.php, core/user.php, modules/account/index.php, and modules/rss_info/index.php to use new filename and CONFIG_DIR constant.
- Minor cleanup in other admin modules (replace.php, referers.php, comments.php) to ensure consistency in getVar usage.